Dictionary expressions: add resolutions for open questions from LDM-2024-03-11 #8074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
approved these changes
Apr 24, 2024
jnm2
reviewed
Apr 24, 2024
| @@ -149,6 +155,7 @@ Which approach should we go with with our dictionary expressions? Options includ | |||
| 2. Purely permissive. All elements are added using the indexer. Perhaps with compiler warnings if the exact same key is given the same constant value twice. | |||
| 3. Perhaps a hybrid model. `.Add` if only using `k:v` and switching to indexers if using spread elements. There is deep potential for confusion here. | |||
|
|
|||
| **Resolution:** Use *indexer* as the lowering form. [LDM-2024-03-11](https://github.com/dotnet/csharplang/blob/main/meetings/2024/LDM-2024-03-11.md#conclusions) | |||
There was a problem hiding this comment.
How should we handle the contradiction between this and the resolution to open question 3:
Dictionary elements will be supported in collection expressions for collection types that have a key-value pair element type.
Which used this example, for which list["mads"] = 21 will not work:
List<KeyValuePair<string, int>> list = ["mads": 21];
There was a problem hiding this comment.
Good catch. Added an open question.
There was a problem hiding this comment.
godo question. my preference is '3'. normal pre-dictionary collection initializable types have 'Add' semantics for their elements. I would prefer to stick with that for sanity/consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.